Wen Hui
Wen Hui
@oranagra Hi Oran, could you please take sometime to check my latest update? Thanks a lot
Hi Oran, I have updated the code and also addressed the comments and replied. And I have even updated json file for 8.0. here are the commit details which had...
Hi @oranagra , Thank you for the help! Failed test cases updated accordingly as suggested. Now we are good to merge, please have a look and help with next steps.
hello @oranagra , I have made all the changes as per code review. Could you please have a look once. Thanks.
@moticless @oranagra Feature and test case ar done, please do a code review when you have time, Thanks a lot
Do we need consider TCL test case redis-compatibility in the thread? Or I need open a new one for test case?
> @hwware i don't understand. Why do we need to change test cases? Just to make CI pass? Sorry confused you. In test case outout, there are some redis keywords...
I partially agree the plan: Agree: add the switch in Valkey 8 Need to discuss: after Valkey 8, how to deal with this switch and next step plan
> valkey.tcl defines a lot of functions and structures called `redis`. This is just confusing. If we rename the client lib, rename the functions and types to valkey too, or...
> This PR is outdated now after #287 was merged. > > #287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still...