Wen Hui

Results 232 comments of Wen Hui

But I doubt, maybe for BITPOS and BITCOUNT, the command format: BITPOS key bit start BYTE | BIT BITCOUNT key start BYTE | BIT should be acceptable as well in...

I think we need to clarify under which condition or provide a reference link , developer should use /* clang-format off */ flag? I think we should describe this in...

@CharlesChen888 Before I review your PR, could you please provide some background information about why you want to update the slowlogCommand to heavyLoadLogCommand? Because in the top comment, you mention...

@furai Since you a new user for our Valkey, I just have one question. Do you feel confused as the following highlight part in json file? ![image](https://github.com/valkey-io/valkey/assets/51993843/3fafbdef-59d9-40b3-b299-bb8608335921) I am not...

I think it makes sense changing redis* to server* here.

@PatrickJS Please rebase and fix the error in CI, Thanks

@madolson do you think we could merge this PR? Thanks

it looks good to me. It is a break change indeed.

Agree with master as an alias of primary. But suggest to hold the master and slave name, maybe they will remove in future version

I am not sure if in cluster v2, is there plan to remove sentinel node?