Wen Hui

Results 232 comments of Wen Hui

Hey @madolson , is there anything that needs to added for this PR or is it fine?

Hey @madolson , I have updated the code and added the gossip functionality for the human readable name. And the node's name can be set manually by using the command:...

> @hwware Hey, now that the hostname extension framework is merged, do you want to follow up on this? I think it should be easy to add a new extension...

Hi @madolson , I agree that this can be used as debugging/human readable name that would be exposed in places like info and logging. This would be better than having...

@madolson , I have added some tests, let me know if you think they are fine. Thanks!

I just quickly take a look the new design for cluster V2, and I need take sometime to consume it. But I have one question: it looks like no concept...

> > I just quickly take a look the new design for cluster V2, and I need take sometime to consume it. But I have one question: it looks like...

@ushachar I reviewed all discussions and description of the cluster v2 spec. I have one concern (aka you could understand maybe this is a bonus for this design). Now in...

I have several questions for this design: 1. As @PingXie comment, if the command **CLUSTER MIGRATESLOTS [NODE ] [SHARD ] ** could support multiply slot ranges, such as CLUSTER MIGRATESLOTS...

I comment out the **r debug loadaof** in the test case, becuase it fails but from my side I do not find any clue that the changes have effect to...