valkey icon indicating copy to clipboard operation
valkey copied to clipboard
verified publisher icon valkey-io

Rename redis.info to valkey.info in LCOV

Open vitahlin opened this issue 2 years ago • 3 comments

Change the name of lcov test as follows: image

vitahlin avatar Apr 08 '24 10:04 vitahlin

LGTM

hwware avatar Apr 08 '24 17:04 hwware

We should automate running with coverage too so they're attached to PR :)

madolson avatar Apr 09 '24 00:04 madolson

We should automate running with coverage too so they're attached to PR :)

We can also display the coverage results in the README.md.

Do you think it's better to open a new PR or deal with it in the current one? @madolson

vitahlin avatar Apr 09 '24 03:04 vitahlin

I personally believe in keeping commits as focused and concise as possible. I'll address the issue of test coverage in a new pull request to ensure its independence and clarity. Thanks for your understanding.

vitahlin avatar Apr 10 '24 03:04 vitahlin