valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Update server function's name to valkey

Open Shivshankar-Reddy opened this issue 1 year ago • 2 comments

Updated valkey in follwing functions.

genRedisInfoString -> genValkeyInfoString genRedisInfoStringCommandStats -> genValkeyInfoStringCommandStats genRedisInfoStringACLStats -> genValkeyInfoStringACLStats genRedisInfoStringLatencyStats -> genValkeyInfoStringLatencyStats

Shivshankar-Reddy avatar May 07 '24 17:05 Shivshankar-Reddy

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.88%. Comparing base (ba9dd7b) to head (829926a). Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #456      +/-   ##
============================================
- Coverage     68.95%   68.88%   -0.08%     
============================================
  Files           109      109              
  Lines         61793    61793              
============================================
- Hits          42611    42565      -46     
- Misses        19182    19228      +46     
Files Coverage Δ
src/server.c 88.60% <100.00%> (ø)
src/debug.c 53.47% <0.00%> (ø)
src/module.c 9.34% <0.00%> (ø)
src/sentinel.c 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

codecov[bot] avatar May 07 '24 18:05 codecov[bot]

I am just curious do we need update these kind of function names? Or at lease so far, do we?

hwware avatar May 07 '24 20:05 hwware