Holt Skinner

Results 164 comments of Holt Skinner

@iamthuya can you merge this PR?

@ravenouse Sorry for the delay in review/updates. There was a repository restructuring that made your PR difficult to merge, but it should be fine now.

General Feedback, can you change the directory to be `gen-app-builder` (The product team is trying to create more "unity" between the disparate features in the product...)

Also, fix lint errors https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/5350373600/jobs/9702887755?pr=76

I cleaned up the commit history, lots of unrelated commits were being added to this PR.

The documentation has been updated to say: https://cloud.google.com/vertex-ai/docs/generative-ai/model-reference/text-chat > For text tasks that can be completed with one API response (without the need for continuous conversation), use the [Text model](https://cloud.google.com/vertex-ai/docs/generative-ai/model-reference/text).

The lint error is a false alarm. I'm adding a commit for a .gitleaksignore to handle this.

@guilhem-martin https://github.com/GoogleCloudPlatform/generative-ai/blob/main/search/web-app/requirements.txt doesn't have a version for `gunicorn` or any other library except `google-cloud-discoveryengine>=0.11.1`. Have you also set the `PROJECT_ID` and other config variables to your own values? And setup...

@SampathkumarSubramaniam Can you provide the input document that caused the issue? (With any PII redacted) This issue seems to be because the text sent to the embeddings model was empty