Holt Skinner
Holt Skinner
Thanks for the catch! LGTM, just make sure to fill out the Google CLA.
@lbjfish Can you provide more context on this issue? Is this part of a Notebook from this repository, or some other kind of code sample?
This repository is for [Generative AI with Vertex AI on Google Cloud](https://cloud.google.com/vertex-ai/docs/generative-ai/learn/overview), not the [Google AI Gemini/PaLM APIs](https://ai.google.dev/). This looks like it could be the JavaScript client library, so you...
@inardini Can you take a look at this?
@anihm136 General comment, it would probably make sense to move those JSON files into a public Cloud Storage bucket instead of having them in the repository. Both to reduce space...
General Comment: I like what you have here, but the notebooks in this repository are intended to use Google Cloud components (specifically Vertex AI). Would it be possible to edit...
That makes sense, I think it would be helpful!
@anihm136 Thanks for making those updates! I have just two more requests: - Change the filename of this notebook to `distillation_step_by_step.ipynb` - We will likely be creating another notebook for...
I understand GCS being an easy way to transmit these files, however they really should be version controlled/tested/linted like the rest of the files. You can also add a cell...
Thanks for the contribution!