Holt Skinner

Results 164 comments of Holt Skinner

Please re-assign to me and re-request review when ready.

FYI - This PR might be obsolete due to the Vertex AI Search retriever being added. I don't see any functionality in this PR that isn't already covered by the...

@yvrjsharma Thanks for your contribution! However, this repository focuses on Generative AI for [Google Cloud Vertex AI](https://cloud.google.com/vertex-ai), and your notebook is using the [Google AI Gemini API](https://ai.google.dev/docs) If you can...

Closing due to inactivity, please re-open if the previous comments have been answered.

I moved the Image and Pickle Files to GCS. The Image paths are already updated with storage.googleapis.com/ links The pickle files are in [`gs://github-repo/generative-ai/sample-apps/accelerating-product-innovation/pickle_files`](https://console.cloud.google.com/storage/browser/github-repo/generative-ai/sample-apps/accelerating-product-innovation/pickle_files) - The file previously in `app/`...

Please re-assign to me and re-request review when ready.

Did the changes in PR #343 fix this issue?

I created PR https://github.com/googleapis/python-aiplatform/pull/3518 for the Vertex AI Python SDK to improve the error messages for this behavior. It will throw a `ResponseValidationError` with specific details as to why the...

For this specific issue, the product development team confirmed the response is blocked by the language filter. I'm going to work on getting this type of error to output a...

@elhadik Thanks for the PR, looks good overall! I just have some comments/suggestions to make it easier to read/more optimized. Note - It looks like your GitHub account does not...