Holt Skinner

Results 164 comments of Holt Skinner

LGTM, just be sure to run black formatter `nox -s blacken` from the repository root.

Related to this: We also should update the "Open In" Links to include Colab Enterprise, now that we can do that for notebooks in this repo. Not sure if we...

Please re-assign to me and re-request review when all comments have been addressed.

@ChrisHanna Can you take a look at this?

I added the files you provided to GCS. These are the new paths: - `backend/src/chatbot_dir/agents/search_agent/preprocessing/table/one_shot/*.txt` → `gs://github-repo/generative-ai/sample-apps/agent-assist/data-prep/*.txt` - `backend/src/data` → `gs://github-repo/generative-ai/sample-apps/agent-assist/backend-data/` - `frontend/src/*.png` → `gs://github-repo/generative-ai/sample-apps/agent-assist/frontend-images` I also moved images used...

I'd still recommend doing some refactoring before I'll go into a deeper review. There's too much to examine at this point.

> > I'd still recommend doing some refactoring before I'll go into a deeper review. There's too much to examine at this point. > > What kind of refactoring should...

I think this is the notebook referenced here: https://github.com/GoogleCloudPlatform/generative-ai/blob/main/language/use-cases/document-qa/question_answering_documents_langchain.ipynb @inardini Can you take a look?

@CodeChamp-SS Can you add a description of your sample app to the PR Description? Also, all of the Images/PDF/CSV files make this PR quite large. These files should really be...

@CodeChamp-SS I moved the requested files to GCS: `gs://github-repo/generative-ai/sample-apps/customer-search/` New Paths: - `gemini/sample-apps/customer-search/files/tables` → `gs://github-repo/generative-ai/sample-apps/customer-search/tables` - `gemini/sample-apps/customer-search/files/CymbalBankWebDeployed/assets` → `gs://github-repo/generative-ai/sample-apps/customer-search/assets/` - `gemini/sample-apps/customer-search/files/FD_TnC.pdf` → `gs://github-repo/generative-ai/sample-apps/customer-search/FD_TnC.pdf` - `gemini/sample-apps/customer-search/files/Market_Summary.pdf` → `gs://github-repo/generative-ai/sample-apps/customer-search/Market_Summary.pdf` You can also...