generative-ai
generative-ai copied to clipboard
Fix display error in refine method and enhance similarity search index with document metadata for document qa with langchain
This PR made two changes to the language/examples/document-qa/question_answering_large_documents_langchain.ipynb notebook:
-
It fixed the display error of the refine method outputs. The original code displayed outputs from the map reduce method instead of the refine method.
-
It changed the similarity search index part in the
Q&A with similarity searchsection. This modification allows themap_reduce_embeddings_outputsto include source information such as page numbers, similar to the previousmap_reduce_outputsandrefine_outputs.
Following the Contributing Guide, I have submitted the CLA and ran the Code Quality Checks.
I kindly request you to review the changes at your convenience. Please let me know if there is anything else I can do to assist with the review process or provide further clarification.
Thank you so much.
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@inardini can you check this PR?
Hi @ravenouse, thanks for the PR. It's quite difficult to review this as I see the entire file has changed. Is there any chance you could re-submit the files with just the changes you made to make this easier?
Hi @polong-lin, thank you so much for the feedback! I have re-submitted the changes. Please let me know what you think about it!
@ravenouse Sorry for the delay in review/updates. There was a repository restructuring that made your PR difficult to merge, but it should be fine now.
Hi @holtskinner, thank you so much for your time on this! Happy New Year!