Ashhar Hasan

Results 136 comments of Ashhar Hasan

~I need to add either another issue template or allow non-templated issues to track such TODO items - it's more noise than information for such issues.~ Not needed, there's a...

one question - why can this new behaviour not be exposed for cursors without `experimental_python_types=true`?

@lpoulain Can you please update behavior to match the JDBC driver (rounding instead of truncation)? Other than that (and possibly allowing using this with experimental_python_types disabled) this seems good to...

@lpoulain Please try using fixup commits when addressing review comments otherwise it's impossible to see what changed between the force push and before that.

@mdesmet See also https://github.com/trinodb/trino-python-client/commit/cffd2b232d9298321c34430f0ac829f6b6ebea8f#r83714277 - not sure if that's the cause.

Also commit message to say: ``` Ensure SQLAlchemy get_table_names only returns tables and not views Per the [SQLAlchemy documentation](https://docs.sqlalchemy.org/en/14/core/reflection.html#sqlalchemy.engine.reflection.Inspector.get_table_names) the get_table_names method is intended to return only table names, i.e.,...

I'd prefer if we made the defaults more useful instead of adding hooks for custom behaviour and leaving users to implement them themselves. It seems default should be to cache...

Ah so the JDBC client maintains two sets - one for added and another for deallocated and when making the requests it merges them together. But here in Python client...

Reopening this to continue discussion.

> Trino Server version > > 388.007 Doesn't look like a real Trino version. Are you running a fork with some modifications? Asking because the header being passed with empty...