Ashhar Hasan

> I think that explicitly calling cancel() on a cursor with no query should raise an an exception, but not so for the implicit cancellation that happens on close(). Yes,...

In my head the logic should be: - On `cursor.close()` - Cancel any already executing queries **if they exist** - Perform implicit ROLLBACK if within a transaction - Set some...

@evansd Me and @hovaesco discussed this offline and we agree with the changes described in my previous comment. So can you please change `cursor.cancel()` behaviour to following: - If query...

@evansd Any updates here?

Thanks for the update @evansd.

Some parts of this were addressed in https://github.com/trinodb/trino-python-client/pull/405

@baohe-zhang Seems the change was merged in server. Once Trino 426 with this change is available please add some tests.

@baohe-zhang The server side change was merged. Can you add some tests here and we can merge this.

What do you actually plan to do? Maybe there's an alternative. We intentionally changed the behaviour to fix a bug where queries which don't return result sets silently swallowed errors....

@ebyhr opinions? I'm not in favour of this since it makes it harder to reason about how session properties at connection and cursor level interact and what happens with cursor...