Ashhar Hasan

Results 136 comments of Ashhar Hasan

@mdesmet @hovaesco I'm fine merging this % https://github.com/trinodb/trino-python-client/pull/208#discussion_r949363282. Can you send a follow-up PR with updated instructions in the README.md?

If I am reading the code correctly the prepared statements path is only used when `params` are provided to `execute`. If not plain SQL is sent as it is. Are...

There is no way today (or before the PR which added prepared statements support) to be able to pass parameters to a query without using prepared statements. If you want...

On second thought, the API allows people to switch between normal and python types on the fly. So ideally pytz must be a required dependency otherwise the code may fail...

Alternative solution implemented in #168.

Fixed by #220. @mdesmet Do you think it's possible to add a test to cover this? I couldn't find any existing test to verify failed queries actually appear failed to...

Acknowledged. Will send a PR once #41 is merged to avoid to rebase/conflicts.

Client side interpolation doesn't seem a good idea because then the client will end up playing catch up with what the server supports. While the end goal is useful (more...

Yes @rsyi, I'm using the Atlas backend. I haven't yet looked into the code but I am assuming with the existing code you somewhat dump all data from remote Neo4j...