Ashhar Hasan

Results 136 comments of Ashhar Hasan

@tangjiangling Sorry for letting this go unattended for so long. Can you please rebase to resolve conflicts and I'll take a look.

Thanks, I'll take another look tomorrow.

RN entry is suggested in the PR description. It might be useful to document the supported range of values but it's not urgent since the values will vary and change...

PT = Product test. You basically provide a dockerized setup with kerberos + Phoenix similar to `EnvMultinodePhoenix5` but with a kerberized Phoenix instead and then run some tests against it...

We're basically missing Bootstrap since we just call `Properties#readProperties` on whatever path is returned by `KafkaConfig#getResourceConfigFiles`. BTW this is one of the downsides of such "escape hatches" provided by ability...

But for other Avro readers to be able to get a timestamp value without manually decoding it the Avro schema needs to annotate the field with a logical type.

I'm a bit confused about this now. I probably need to re-read existing code more thoroughly and re-review later. In meantime I'll defer to @Praveen2112 .

FYI @martint @sopel39

@damnMeddlingKid A session property is good to have but unless the implementation has issues which make it not ideal to be used generally I suggest we enable it by default...