trino-python-client icon indicating copy to clipboard operation
trino-python-client copied to clipboard

Send extra credentials only in the initial request instead of every request

Open hashhar opened this issue 2 years ago • 3 comments

Client should send extra credentials only on the initial request.

See https://github.com/trinodb/trino/issues/14364#issuecomment-1263432919 for more context.

hashhar avatar Oct 01 '22 15:10 hashhar

~I need to add either another issue template or allow non-templated issues to track such TODO items - it's more noise than information for such issues.~

Not needed, there's a Don’t see your issue here? Open a blank issue. button at the bottom already.

hashhar avatar Oct 01 '22 15:10 hashhar

@hashhar I would like to take this. Could you please give me some pointers, to begin with? I have skimmed through client.py and auth.py but was not able to understand where we make the initial connection and how we check if it's an initial request?

aakashnand avatar Jan 23 '23 13:01 aakashnand

@aakashnand: The initial request is the query submission, i.e. the POST statement, the subsequent GET statements or other API calls shouldn't include the extra credentials.

Let me know if this helps.

mdesmet avatar Mar 01 '23 09:03 mdesmet