Ashhar Hasan

Results 136 comments of Ashhar Hasan

I'll be able to look at this over the next weekend. I think it's much better to write an extractor for Atlas rather than Amundsen since people using Atlas without...

See also https://github.com/alastair/python-musicbrainzngs/pull/259 which seems to be related I think.

I've made the changes and have tested them part from the "release-groups" collections. I though about adding tests but not sure if you'd want to test against actual MusicBrainz. Let...

@alastair can you PTAL at this.

FYI, my work can be followed at https://github.com/hashhar/python-musicbrainzngs/tree/extended-collections but there won't be anything to see there until someone (@alastair ?) can let me know which way to go. As a...

@alastair I think I'm going with the approach used in the `_do_collection_query` and the methods that use it. It'll allow using both named functions and an easy way to add...

I think my idea would've made the interface a little difficult to use. I was thinking of exposing the `_do_collection_put` and `_do_collection_delete` methods as public ones and not add the...

@alastair just wanted to remind you of this PR. I've tested this with all the new endpoints that I've added and it's working. One concern I had was that right...

@alastair Just wanted to check if you had a chance to look at this.