trino-python-client icon indicating copy to clipboard operation
trino-python-client copied to clipboard

Published 20 hours ago • verified publisher icon trinodb

Make client module private

Open findepi opened this issue 4 years ago • 3 comments

rename client to _client.

relates to https://github.com/prestosql/presto-python-client/pull/41#issuecomment-689613917

cc @hashhar

findepi avatar Sep 09 '20 15:09 findepi

Acknowledged. Will send a PR once #41 is merged to avoid to rebase/conflicts.

hashhar avatar Sep 09 '20 16:09 hashhar

@hashhar If we update the public facing API, can we import connection as a peer to the dbapi module? This matches what is done SQLAlchemy and PyODBC and should be able to be done in a backward compatible way.

joshthoward avatar Jan 15 '21 14:01 joshthoward

This is free to take.

findepi avatar Mar 01 '21 15:03 findepi