Steven Green

Results 33 comments of Steven Green

``` Checking drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_1_phase.lua 1 warning drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_1_phase.lua:15:7: (W211) unused variable st_utils Checking drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_2_phase.lua 1 warning drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_2_phase.lua:15:7: (W211) unused variable st_utils Checking drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_3_phase.lua 1 warning drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_3_phase.lua:15:7: (W211) unused variable st_utils ```

We'd prefer the original set of preferences included when this was first submitted. Some of the new preferences added, especially the bitmasks, don't make a ton of sense when presented...

@mh-zwave 5 minutes is okay.

``` Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric ```

> ``` > Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning > > drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric > ``` This still needs to be fixed in the meantime as well.

We haven't attempted to add device to any groups because it hasn't responded with (as @orangebucket correctly pointed out) a binding table response.

@shinasys Because group 0x0000 is invalid in the zigbee spec we had disallowed drivers from using it. However, because so many devices use it anyway, we'll be adding it back...

Looks like you'll also need to update the test. I'd also suggest adding a few more. I'd suggest adding one that sets the mode. That way this error could have...

@inasail added two more that I missed, robb and the aqara version sub-driver

tests are failing because this is based on a branch prior to https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1858 , but should be fine now if rebased