Steven Green
Steven Green
You'll need to rebase your branch to resolve the conflicts with the localization file.
``` Checking drivers/SmartThings/zigbee-power-meter/src/bituo/init.lua 1 warning drivers/SmartThings/zigbee-power-meter/src/bituo/init.lua:260:1: (W611) line contains only whitespace ```
Also, please add some unit tests.
@script0803 I'd first follow this guide: https://developer.smartthings.com/docs/devices/hub-connected/set-up-dev-env using the artifact containing the lua libraries here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/releases/tag/apiv15_58 Then navigate to your driver's `src` directory and simply run `lua test/[name_of_your_test_file].lua`
@script0803 can you include your test in the PR here so I can take a look?
Your configuration test failures are because your fork needs to be rebased. There have been upstream changes in the main repo that are not included in your fork.
@script0803 Please rebase your pull request to remove the merge conflicts.
@xiaodah123 @simon3panda perhaps you forgot to push to your branch? You will also need to re-base your branch to resolve the conflicts.
It would be good if you added some tests of your device's specific behavior. A good template would be this test file, which also bases its behavior off the value...
@simon3panda Yep. Assuming you've set up you dev environment following the instructions here: https://developer.smartthings.com/docs/devices/hub-connected/set-up-dev-env Once you've done that, you can navigate in your terminal to the `src` directory of the...