SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

update popp thermostat

Open mh-zwave opened this issue 1 year ago • 5 comments

mh-zwave avatar Jun 12 '24 11:06 mh-zwave

Hi Team, this one is coming from Aeotec. They are looking to make a minor fix for the /popp subdriver. This device is already WWST certified. Please let us know if there are any issues with the change they would like to make.

Brianj94 avatar Jun 13 '24 15:06 Brianj94

Test Results

   60 files    377 suites   0s :stopwatch: 1 823 tests 1 823 :white_check_mark: 0 :zzz: 0 :x: 3 161 runs  3 161 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 94576a37.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 20 '24 20:06 github-actions[bot]

File Coverage
All files 89% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua 88% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua 81% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/leviton/init.lua 89% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua 89% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua 78% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua 90% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 94576a375524f8d26f921e9325e796fb834c440a

github-actions[bot] avatar Jun 20 '24 20:06 github-actions[bot]

Looks like you'll also need to update the test.

I'd also suggest adding a few more. I'd suggest adding one that sets the mode. That way this error could have been detected earlier.

greens avatar Jun 20 '24 20:06 greens

Channel deleted.

github-actions[bot] avatar Jun 27 '24 18:06 github-actions[bot]