Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch

[InovelliUSA]

[CLAassistant]

All committers have signed the CLA.

[lelandblue]

Hey @InovelliUSA Can you check out the open comment above on this PR please at your nearest opportunity? Thank you!

[InovelliUSA]

Hey @InovelliUSA Can you check out the open comment above on this PR please at your nearest opportunity? Thank you!

Sure, I will check it out right now.

[InovelliUSA]

I believe I have adjusted everything requested. I did find a bug that I addressed in info_changed as well. Other than that, I just changed what was asked.

https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1497/commits/8d4ab6a452439431d36250e2626b97ba2725643d

[github-actions[bot]]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions[bot]]

Test Results

   64 files    406 suites   0s ⏱️ 2 013 tests 2 013 ✅ 0 💤 0 ❌ 3 489 runs  3 489 ✅ 0 💤 0 ❌

Results for commit 7c502a54.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

File	Coverage
All files	91%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/ge-link-bulb/init.lua	95%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua	37%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua	93%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/multi-switch/init.lua	87%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua	94%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua	98%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/init.lua	73%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/vimar/init.lua	70%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/enbrighten-metering-dimmer/init.lua	91%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua	95%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/wallhero/init.lua	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/aurora-relay/init.lua	80%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/jasco/init.lua	94%	:white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 7c502a54d468830ee1a279b443268f44abd9250e

[greens]

Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning

    drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric

[lelandblue]

Hey @InovelliUSA Thanks so much.

We noticed that there arent yet Unit Tests written for this driver. We should have called this out a bit sooner, so apologies. I will recommend that we continue with the WWST process and we can review the driver tests in parallel. To learn more about unit driver tests, please see https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

[greens]

Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning

    drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric

This still needs to be fixed in the meantime as well.

[InovelliUSA]

Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning

    drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric

This still needs to be fixed in the meantime as well.

This should be fixed now.

[lelandblue]

Hey @InovelliUSA Thanks so much.

We noticed that there arent yet Unit Tests written for this driver. We should have called this out a bit sooner, so apologies. I will recommend that we continue with the WWST process and we can review the driver tests in parallel. To learn more about unit driver tests, please see https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

Hey @InovelliUSA - Can you let me know if you have any questions on the above message please? Thank you.

[InovelliUSA]

Hey @InovelliUSA Thanks so much. We noticed that there arent yet Unit Tests written for this driver. We should have called this out a bit sooner, so apologies. I will recommend that we continue with the WWST process and we can review the driver tests in parallel. To learn more about unit driver tests, please see https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

Hey @InovelliUSA - Can you let me know if you have any questions on the above message please? Thank you.

I have always tested with the device itself, so I haven't created the unit tests. I will have to research how to do that.

[github-actions[bot]]

Channel deleted.

[lelandblue]

@InovelliUSA Can you please review and sign the CLA? Thank you!

[lelandblue]

Hello - I am going to close this PR. If it needs to be reopened, it can be. Thank you.

[github-actions[bot]]

Channel deleted.

[lelandblue]

Hello @InovelliUSA We can merge this PR and deploy, however we need a signature on the CLA. Can you please review at your nearest opportunity?

Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.

[InovelliUSA]

Hello @InovelliUSA We can merge this PR and deploy, however we need a signature on the CLA. Can you please review at your nearest opportunity?

Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.

Sorry about that, I think I just completed it.

[lelandblue]

It appears that @erocm123 needs to still sign, are they available to sign the CLA?