Aeotec Home Energy Meter Gen8

[mh-zwave]

Check all that apply

Type of Change

• [x ] WWST Certification Request
  • If this is your first time contributing code:
    • [x] I have reviewed the README.md file
    • [x] I have reviewed the CODE_OF_CONDUCT.md file
    • [x] I have signed the CLA
  • [x ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• [ ] Bug fix
• [ ] New feature
• [ ] Refactor

Checklist

• [ ] I have performed a self-review of my code
• [ ] I have commented my code in hard-to-understand areas
• [ ] I have verified my changes by testing with a device or have communicated a plan for testing
• [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

[github-actions[bot]]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions[bot]]

Channel deleted.

[github-actions[bot]]

Test Results

   67 files  +  1    443 suites  +23   0s ⏱️ ±0s 2 273 tests +121  2 273 ✅ +121  0 💤 ±0  0 ❌ ±0  3 907 runs  +234  3 907 ✅ +234  0 💤 ±0  0 ❌ ±0 

Results for commit b93df6ad. ± Comparison against base commit 0db6c689.

This pull request removes 4 and adds 125 tests. Note that renamed tests count towards both.

Operational state should generate correct messages
Test battery alert handler
closed contact events
open contact events

Battery level report should be handled
Battery percentage report should be handled (button)
Battery percentage report should be handled (motion illuminance)
Capability command setFanMode should be handled
Capability command setPercent should be handled
Capability off command switch off should be handled : dp 1
Capability off command switch off should be handled : dp 2
Capability off command switch off should be handled : dp 3
Capability off command switch off should be handled : dp 4
Capability off command switch off should be handled : dp 5
…

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

File	Coverage
All files	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/preferences.lua	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/2-phase/init.lua	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/3-phase/init.lua	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/1-phase/init.lua	97%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/init.lua	96%	:white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against b93df6adf2afeedc94377f1b07fada014b33a3cc

[lelandblue]

Hey @Brianj94 - Tagging you for your awareness :)

[lelandblue]

Hello @mh-zwave Thank you for your PR. Please review the above comments and address them so that the review can proceed at your nearest opportunity. Thank you.

[greens]

Checking drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_1_phase.lua 1 warning

    drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_1_phase.lua:15:7: (W211) unused variable st_utils

Checking drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_2_phase.lua 1 warning

    drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_2_phase.lua:15:7: (W211) unused variable st_utils

Checking drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_3_phase.lua 1 warning

    drivers/SmartThings/zwave-electric-meter/src/test/test_aeotec_home_energy_meter_gen8_3_phase.lua:15:7: (W211) unused variable st_utils

[greens]

We'd prefer the original set of preferences included when this was first submitted. Some of the new preferences added, especially the bitmasks, don't make a ton of sense when presented in our preferences UI.

[mh-zwave]

I’ve removed some of the parameters. For those we still consider important, I’ve restricted the minimum and maximum values more tightly than what the device technically supports. I believe this is a good compromise and can be represented more effectively in your preference UI.

[mh-zwave]

Alright, I'll remove the newly added preferences again. Is it an issue that we set the reporting interval for power consumption to 5 minutes to ensure the powerConsumption report always provides a current value? Or could this cause problems for the hub?

[greens]

@mh-zwave 5 minutes is okay.