SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

New Device (Zigbee Lock) Nimly Door Lock

Open lelandblue opened this issue 11 months ago • 4 comments

Type of Change

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Refactor

Checklist

  • [ X ] I have performed a self-review of my code
  • [ ] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR is adding a fingerprint only for a device seeking WWST Submission. Further device testing is planned.

The device is a Zigbee Lock.

Summary of Completed Tests

lelandblue avatar Jan 09 '25 17:01 lelandblue

tests are failing because this is based on a branch prior to https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1858 , but should be fine now if rebased

greens avatar Jan 09 '25 22:01 greens

File Coverage
All files 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua 98% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/yale/init.lua 81% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 11c4c03ee11e731b3a6fda59f8c8a7c0c82f05f1

github-actions[bot] avatar Jan 10 '25 15:01 github-actions[bot]

Invitation URL: https://bestow-regional.api.smartthings.com/invite/RBlE5LWy5lEA

github-actions[bot] avatar Jan 10 '25 15:01 github-actions[bot]

Test Results

   64 files    404 suites   0s ⏱️ 2 009 tests 2 009 ✅ 0 💤 0 ❌ 3 471 runs  3 471 ✅ 0 💤 0 ❌

Results for commit 11c4c03e.

github-actions[bot] avatar Jan 10 '25 15:01 github-actions[bot]