Marco Granelli

Remove wrapper fee unshielding

2

## Describe your changes Partially addresses #2597. Removes the optional fee unshielding `Transaction` object from `WrapperTx`. Removes/refactors associated functions, types and tests. Removes fee unshielding support from the client and...

We should ensure to have at least one test that checks the correctness of the proofs/signatures verification in the masp vp. All the integration tests run with mocked builder/verifier so...

Remove masp vp dependency on `Transfer`

1

## Describe your changes Closes #3148. ## Indicate on which release or other PRs this topic is based on ## Checklist before merging to `draft` - [ ] I have...

Refactor inner `Tx`s interface

3

Possible improvement of the way we access the section commitments of an inner tx ```rs enum TxCommitmentRef { Id(TxCommitments), Hash(Hash), Index(usize), } impl TxCommitmentRef { fn get_commitments( &self, batch: impl...

Review `ResultCode::WasmRuntimeError` for batch errors

4

Based on https://github.com/anoma/namada/pull/3103#discussion_r1593546470 we should review the use of this specific error code and maybe create a new one

Convert description check is unnecessarily strict

1

Convert descriptions could point to older anchors (just like spend descriptions do). This requires keeping in storage old versions of the tree anchor, updating the validation in the validity predicate...

We could introduce an early check in the masp vp to reject a transaction carrying an invalid `sapling_value_balance`. These transactions are already rejected by the masp vp but this happens...

The followings should be addressed: - wrong error message (source not target) https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L353-L356 - Strenghten this check (check that the set is non-empty) https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L326-L329 - Misleading error message https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L328-L329 -...

Update gas for storage occupation

2

## Describe your changes Increases the gas cost component for storage occupation and ties this cost the other ones so that it's not free-floating anymore (which could cause a divergence...

Outsource masp signature verification

2

## Describe your changes Closes #3312. Swaps the signature verification call in the masp vp with a check on the triggered vps. Introduces a new masp `Action` to support signature...