Marco Granelli

Currently we check some signatures in the masp vp when the balance changes of a transaction do not match the state transition implied by the masp `Transaction`. We might be...

This is a possible(?) breaking improvement of the signature check in the MASP VP. > Could the signature check in the masp vp be done only if the balances decrease...

Fix transfer triggered vps

1

## Describe your changes ## Checklist before merging - [ ] If this PR has some consensus breaking changes, I added the corresponding `breaking::` labels - This will require 2...

Unsigned MASP `Changes` in SDK

1

## Describe your changes Closes #3425. Modifies the `Changes` type in the SDK to wrap `U128Sum` instead of `I128Sum` since changes are guaranteed to be non-negative. Also adjusts `from_masp_denominated_i128` and...

Improve `Speculative ShieldedContext`

2

#2534 introduces the `Speculative` context in the client to invalidate masp spent notes so that the client does not end up reusing the same notes when constructing new transactions which...

The `Tx` struct supports including the transaction code either as the hash of the code to execute (to be retrieved from storage or from cache if already compiled) or as...

From Informal Systems' audit. ## Description The MASP VP performs several checks related to IBC message processing, including: • `check_ibc_transfer` • `check_packet_receiving` • `is_receiving_success` These checks appear to duplicate functionality...

Improve MASP fee payment UX

2

Some suggestions coming from https://github.com/anoma/namada/issues/3961#issuecomment-2447810438 (thanks @Rigorously). The implementation of masp fee payment in the client (as of #3959) has some flaws: - The client always require to pass in...

Reduce masp events

6

Right now, if a transaction contains at least a valid masp transfer, we emit two attributes in the tx event: 1. `masp_tx_block_index` to point to the transaction in the block...

Better management of disposable keys in wallet

1

We currently run a cleanup procedure of expired disposable keys when generating a new one: https://github.com/anoma/namada/blob/47fc912f9afbd36dd23d9597630a1e89497541ff/crates/wallet/src/lib.rs#L808-L834 Since we plan to use disposable keys more now, this logic can turn out...