namada icon indicating copy to clipboard operation
namada copied to clipboard

Review `ResultCode::WasmRuntimeError` for batch errors

Open grarco opened this issue 1 year ago • 4 comments

Based on https://github.com/anoma/namada/pull/3103#discussion_r1593546470 we should review the use of this specific error code and maybe create a new one

grarco avatar May 08 '24 15:05 grarco

Depends on #3103

sug0 avatar May 13 '24 12:05 sug0

@grarco Would this change be breaking or not?

cwgoes avatar Aug 22 '24 07:08 cwgoes

To me it looks like, as long as we don't shift the variants of the ResultCode enum but we just add new ones, this should be a non-breaking change

grarco avatar Aug 22 '24 08:08 grarco

Also, we should consider adding one more ResultCode variant for failed atomic batches that performed masp fee payment: in this cases we still commit the first transaction of the batch that was needed for the fees (and we drop everything else). We should think about adding another variant to better convey this message to external tools so that it's more clear that the first tx should still be kept into account

grarco avatar Mar 06 '25 08:03 grarco