namada
namada copied to clipboard
MASP minor adjustments
The followings should be addressed:
- wrong error message (source not target) https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L353-L356
- Strenghten this check (check that the set is non-empty) https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L326-L329
- Misleading error message https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L328-L329
- Potential overflows:
- https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/shielded_token/src/conversion.rs#L320-L321
- https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/shielded_token/src/conversion.rs#L368
- https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/shielded_token/src/conversion.rs#L283-L286
- https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/shielded_token/src/conversion.rs#L335C17-L345
- MIsleading comment https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/shielded_token/src/conversion.rs#L289-L297
- Try to share code between https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L342-L406 and https://github.com/anoma/namada/blob/f7532c20072fd877046857f567735770389cd1d0/crates/namada/src/ledger/native_vp/masp.rs#L466-L513