namada icon indicating copy to clipboard operation
namada copied to clipboard

Remove wrapper fee unshielding

Open grarco opened this issue 1 year ago • 2 comments

Describe your changes

Partially addresses #2597.

Removes the optional fee unshielding Transaction object from WrapperTx. Removes/refactors associated functions, types and tests. Removes fee unshielding support from the client and the sdk.

NOTE: with this PR only transactions that pay fees from the signer balance are accepted. If you need to test masp transactions you'll need to have enough funds in a transparent balance.

Indicate on which release or other PRs this topic is based on

#3103 (diffs for review: https://github.com/anoma/namada/pull/3217/files/7f4b6c1e6656ec44194562ad1e167b09d24170f4..cf52c605e33279f4f464b210a8e215a7138be809)

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

grarco avatar May 09 '24 16:05 grarco

Codecov Report

Attention: Patch coverage is 46.82689% with 1416 lines in your changes are missing coverage. Please review.

Project coverage is 60.63%. Comparing base (4ed6229) to head (c2e98ab).

Files Patch % Lines
crates/sdk/src/signing.rs 0.00% 742 Missing :warning:
crates/sdk/src/tx.rs 0.00% 199 Missing :warning:
crates/namada/src/ledger/protocol/mod.rs 60.79% 69 Missing :warning:
crates/sdk/src/masp.rs 0.00% 66 Missing :warning:
crates/tx/src/types.rs 59.23% 53 Missing :warning:
crates/apps/src/lib/bench_utils.rs 0.00% 52 Missing :warning:
crates/sdk/src/rpc.rs 0.00% 46 Missing :warning:
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 90.25% 42 Missing :warning:
crates/apps/src/lib/node/ledger/shell/mod.rs 82.25% 11 Missing :warning:
crates/tx_prelude/src/lib.rs 0.00% 11 Missing :warning:
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3217      +/-   ##
==========================================
+ Coverage   60.24%   60.63%   +0.38%     
==========================================
  Files         303      303              
  Lines       93191    93550     +359     
==========================================
+ Hits        56145    56721     +576     
+ Misses      37046    36829     -217     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 17:05 codecov[bot]

@yito88 this pr changes the structure of the Tx once more so we'll probably need another update of Hermes

grarco avatar May 10 '24 16:05 grarco