namada icon indicating copy to clipboard operation
namada copied to clipboard

Update gas for storage occupation

Open grarco opened this issue 1 year ago • 2 comments

Describe your changes

Increases the gas cost component for storage occupation and ties this cost the other ones so that it's not free-floating anymore (which could cause a divergence if the other costs are changed).

Removes the redundant new_from_sub_limit constructor for TxGasMeter.

Indicate on which release or other PRs this topic is based on

#3428 (diff for review: https://github.com/anoma/namada/pull/3510/files/209da0c6ad9cd456a5a6634ec25cc45408e0b72c..33a6cc9437692ccb1ef24e58f2536ac2dfdeb8f3)

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

grarco avatar Jul 12 '24 15:07 grarco

Let's wait for the CI to come back online before reviewing this cause there's a change we might have a few tests failing due to gas

grarco avatar Jul 12 '24 15:07 grarco

Codecov Report

Attention: Patch coverage is 78.92377% with 47 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (8479d38) to head (33a6cc9). Report is 4 commits behind head on main.

Files Patch % Lines
crates/node/src/bench_utils.rs 0.00% 14 Missing :warning:
crates/namada/src/ledger/protocol/mod.rs 70.00% 9 Missing :warning:
crates/gas/src/lib.rs 76.19% 5 Missing :warning:
crates/sdk/src/rpc.rs 0.00% 5 Missing :warning:
crates/tx/src/data/mod.rs 91.07% 5 Missing :warning:
crates/node/src/shell/finalize_block.rs 83.33% 3 Missing :warning:
crates/tx/src/data/wrapper.rs 62.50% 3 Missing :warning:
crates/light_sdk/src/reading/asynchronous/tx.rs 0.00% 1 Missing :warning:
crates/namada/src/ledger/mod.rs 90.00% 1 Missing :warning:
crates/node/src/shell/governance.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   53.48%   53.46%   -0.02%     
==========================================
  Files         320      320              
  Lines      110000   109964      -36     
==========================================
- Hits        58832    58792      -40     
- Misses      51168    51172       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 15 '24 14:07 codecov[bot]

Let's wait for the CI to come back online before reviewing this cause there's a change we might have a few tests failing due to gas

Ok I've fixed the broken tests, this PR is now ready for review

grarco avatar Jul 16 '24 09:07 grarco