German Velasco

Results 121 comments of German Velasco

@aleDsz yeah, I think adding the `__using__/1` macro to the `Interceptor` module would make sense so that we can make sure at least one of the `call` functions is implemented.

Thanks for mentioning this @seivan . I'm not a 100% sure, but I think you could make this work already _as is_ by using [Bamboo.SentEmail](https://github.com/thoughtbot/bamboo/blob/master/lib/bamboo/sent_email.ex)? That's what the `LocalAdapter` uses,...

Hi @ijunaid8989 thanks so much for opening the issue and for the patience! I'm just starting to maintain Bamboo and trying to look through the open issues. This seems related...

Hi @fuelen thank you for opening this issue. I understand that in theory allowing iodata would improve performance. But I'm wondering, are you experiencing performance issues with Bamboo right now?...

> I've worked on custom templating engine and realized, that I've to convert iodata to string manually, because bamboo doesn't support iodata. Ohhh, got it. Thanks for adding that clarity...

Hi @ruudk, thanks for the ping on this. I don't know that there is an easy fix to this. I took a peak at the implementation, and like other comments...

@ruudk yes! That's exactly what I'd like us to do in `assert_email_delivered_with`, but it's tough to know which parts to pattern match on. Or at least, I haven't thought it...

Thanks for opening this PR @astjohn. Do you have any links to Mailgun documentation that I could reference to help me review this PR?

@astjohn, thanks so much for looping back and rebasing the PR to be up to date! Would you mind adding a test for the MailgunAdapter so the changes are tested?...

@PJUllrich thanks so much for opening this issue. Apologies for the delay. I can see how it might be valuable to have a function that could ensure an email is...