German Velasco

Results 121 comments of German Velasco

@jounimakela thanks for the patience and understanding with this. I'm just going to close this. I think your last bullet point sums it up well: > Or we can just...

Thanks for opening this issue. Glad you found a workaround for now. If you're interested in contributing, I'd be happy to review a PR with a fix for this. If...

Yeah, I'm not opposed to the library adding something like that. I think I would name it `assert_text` since we're asserting there's some text on the page. I'd be happy...

That's an interesting thought. I think we read it from different angles (which is always interesting!) This is where my head's at 👇 As a user of the library, I...

Looping back on this, we can introduce an `assert_text/2` if people still want it. But I think if we do, we should make it so assertions don't fail on apostrophes...

@srcrip that sounds good. If you (or someone else is interested in contributing this), I'd be happy to review a PR!

Thanks so much for opening the issue here and in LiveView Randy! I'll keep an eye on the LiveView issue to see what they say.

Hey @mattwynne. So good to hear from you! You're not the first to think of having an `assert_download` would be good. I'm intrigued by your solution because I've been wondering...

@siraj-samsudeen thanks for opening this. I'm not sure if this is a more appropriate issue for `mix test.interactive` or for phoenix_test. In any case, PhoenixTest cannot yet configure the endpoint...

Thanks @ftes. I think this makes sense. Selects are slightly different from inputs since selects have options. But I get why we'd want a similar helper. Question for you: is...