German Velasco comments

Results 121 comments of


                                            German Velasco

Error when testing add/remove of nested forms - data getting out of sync?

@sevenseacat I'm sad to say that I tested out `main` on a couple of apps that I use to check for regressions, and the changes in #208 introduce a bad...

Add credo NoOpenBrowser check

@ftes thanks for all the work on this. I'm going to rebase this branch and get it merged.

Feature request: `assert_checked/{2,3}` and `refute_checked/{2,3}`

@s3cur3 sorry for taking so long to respond. Been busy. Yes, I recently introduced the ability to assert a field's value in 515242d by pointing at the label. It abuses...

click_button does not respect the name attribute of the button

@egze thanks for opening the issue! ~~Could you create a sample repo that reproduces the error?~~ EDIT: just saw the open PR (I was going through issues first 😄 )....

click_button does not respect the name attribute of the button

This was fixed in #220

Proposal: build with `live_isolated` to unit test live_components

Hey @totaltrash thanks for opening this issue! Testing isolated LiveComponents can be such a pain (usually I test them _through_ their parent LiveView). But it would be great to be...

click_button faile with `** (ArgumentError) Could not find element with selector`

@barnabasJ thanks for opening an issue! Could you create a sample repo that reproduces the error?

click_button faile with `** (ArgumentError) Could not find element with selector`

Thanks @barnabasJ and @capoccias! I haven't had time to look into this. If either of you (or anyone else stumbling here) wants to take a stab at fixing this, I'd...

click_button faile with `** (ArgumentError) Could not find element with selector`

Thanks for checking into this @capoccias! I'm going to close this issue since it seems resolved. If anybody in this thread (@barnabasJ @alexslade ) is still running into this issue...

Document 'open_browser' credo check

I think that's a really cool idea! I wouldn't mind that being documented in the docs (maybe by the `open_browser` docs) or included in the library. I wonder... is there...