bamboo
bamboo copied to clipboard
SentEmailViewer should work with with all adapters.
It would be nice if SentEmailViewer
still worked with other adapters, maybe LocalAdapter
could be an add-on and not just the only one used.
The rational is that we're using SES Mailbox Simulator for non prod environments, and would love to be able to use it while still having access to the SentEmailViewer
.
My suggestion is that LocalAdapter
should not be a replacement for an actual adapter, but an addition.
Is this something that's acceptable? In which case I don't mind setting up a PR for it.
Thanks for mentioning this @seivan . I'm not a 100% sure, but I think you could make this work already as is by using Bamboo.SentEmail? That's what the LocalAdapter
uses, right?
So if you wrote your own adapter that uses SentEmail
to store and fetch the emails, then you might be good to go? I know that's technically internal workings of LocalAdapter
and SentEmailViewer
and thus liable to change, so it might be good to make it official somehow. But for now, would that solve your problem?
@germsvel Sorry for the delay.
But the documentation states To see emails you must use the Bamboo.LocalAdapter.
This seems a bit unnecessary, this should be configuration on Bamboo itself and not an adapter implementation.
So I am wondering if it's possible to add the option to enable Bamboo.SentEmail
regardless of adapter usage?
If not, are you open to the idea? I would need some help with testing but I don't mind writing a PoC.