German Velasco

Results 121 comments of German Velasco

@ftes is this Credo check something you're still interested in? If so, I think we could put one into the codebase itself (happy to review a PR 😄 ) and...

@ftes just looking at this now. I understand the desire to not need to use JS for a test like this. But I'm always hesitant to break the encapsulation PhoenixTest's...

> My problem is that it's either or. Either PhoenixTest form handling start to finish (fill + submit) OR custom form handling. But not interleaved. Yeah, that makes total sense....

> Unlike the unwrap extension you proposed, fill_in_hidden seems to me less opinionated because it operates at the DOM/HTML abstraction level. Yeah, I think it would be nice to find...

@jounimakela thanks for opening this issue. I think the problem isn't with `phoenix_test` itself. We're passing the `path` to [`Phoenix.ConntTest.get`](https://hexdocs.pm/phoenix/Phoenix.ConnTest.html#get/3), which seems to treat that as the root path. Would...

I think this is also related to #72 (though probably need different fixes). Just noting that here.

@jounimakela any thoughts on my comment from before? (https://github.com/germsvel/phoenix_test/pull/80#issuecomment-2149702937)

Thank you! 🎉 And no apologies needed. This is open source, so we all work on it when we can. 😄 Just wanted to check if this was still something...

Thanks for making the change! --- > I am not too happy about having the helper function in the top-level module. Yeah, I agree. Something about it doesn't feel great....

@jounimakela it's been a long time since this PR was opened. Sorry that we haven't moved it forward. I think that since Phoenix is not going to change how they...