German Velasco comments

Results 121 comments of


                                            German Velasco

Support assert_has value finder for select

Yeah, I think that makes sense. I have a _slight_ worry that people might get confused about things, but hopefully we can clarify in docs. So, what I have in...

When `click_button/2` is used to submit a form `Form.build/1` selects the first button even if it is `type=button`

@dabaer thanks for opening this issue! Yeah, it doesn't surprise me that we were looking into the first button regardless of its type. But we should fix that. You open...

`uncheck` doesn't work with array named fields

Thanks for opening this issues @balexand! Would you be interested in adding a PR to fix this?

Find by aria-label

Hey @jaimeiniesta! Yes, I'd love to support that at some point. I made some initial strides in places like when we [click a button]()https://github.com/germsvel/phoenix_test/blob/fe5e986bc3f51dd18688383fbe1d5535cd5b3774/lib/phoenix_test/live.ex#L65), it'll try to find a button...

Proposal: Make it possible to change interval wait time if timeout is less than 100ms

@nicanor thanks for opening this issue! It makes sense to me that the timeout would be configurable. I like the default of 100ms, but happy to review a PR that...

check() no working with checkbox groups

Hi @jk-lamb thanks for opening an issue. Could you provide a sample application to reproduce the error?

Dynamic endpoint

@jpyamamoto is this something we still want to get into PhoenixTest? Not trying to add pressure (I'm the first to know we all have _other_ stuff to do). But wanted...

Support Regex in `assert_path/2`

I can see the value in it. I worry a little that there will be an expectation that all assertions take a regex, but maybe we cross that bridge when...

Let `open_browser` accept 2nd arg `open_fun`

@peaceful-james I'd be happy to review a PR if you want to introduce one. We just need to make sure to cover the LiveView and Static cases. Do you mind...

Form tests fails if the form does not have validation

Thanks for opening this issue @Wigny, and for adding a sample repo with a test failure 🙏 (that's huge help!) I haven't had time to look at this yet, but...