Gary Gregory comments

Results 851 comments of


                                            Gary Gregory

Remove duplicate condition in FixedOrderComparator equals()

Hello @saurabh-rahate Thank you for your PR. Would you please resolve conflicts and rebase on master?

Remove duplicate condition in FixedOrderComparator equals()

@saurabh-rahate - Thank you for your PR, see my notes for future contributions. - This was done differently in git master. - You are credited in `changes.xml`. - Closing this...

Amend description of FilenameUtils#getFullPathNoEndSeparator(String) to reflect correct named user result with trailing slash

Note that we should not treat ~ in any special way since it is a Unix-like shell utility and not a file system functionality.

Amend description of FilenameUtils#getFullPathNoEndSeparator(String) to reflect correct named user result with trailing slash

Hello @Philzen It looks to me like git master already contains the Javadoc change. What about all the callers of the API?

Bump org.slf4j:slf4j-simple from 1.7.26 to 2.0.17

@dependabot rebase

Bump org.slf4j:slf4j-simple from 1.7.26 to 2.0.17

@dependabot rebase

When logging exceptions, the exception stack traces include dynamically generated class names, which leads to a memory leak.

Nice reproducer @ppkarwasz !

Fix Flaky Tests

@qz0610 Please make your tool write its files to the `target` folder, NOT the root!

Hello @qz0610 Please rebase on git master and explain how this failure went away: ``` [ERROR] BeanModelTest>BeanModelTestCase.testBooleanPredicate:681->JXPathTestCase.assertXPathValueIterator:152 Evaluating value iterator expected: but was: ``` The change is the addition of...

Add ArrayUtils.binarySearch() with a key extractor

> > Hello @kvr000, > > This code should be in `ArrayUtils`. TY! > > @garydgregory : Yeah, got it, was busy to finish that. Fixed now, thank you. @kvr000...