Gary Gregory

Results 851 comments of Gary Gregory

The simplest is to use macos-13. The title here is "Assume everyone is on Java 5 or later" which is not the case, we need Java *8* or later.

@Ben-Waters Not directly related, but do you have any thoughts on https://github.com/apache/commons-codec/pull/36?

I just re-read the comments it seems like: - We are not sure if the current code implements the "plain" or original algorithm. - We don't have access to, or...

@kvr000 Please only provide only one binarySearch() API in this PR, like `ArrayUtils` in Commons Lang, no First/Last API.

Hi @Claudenw -1: Please see the email thread from way back in July: https://lists.apache.org/thread/44dr03zs4zr92yypgxgsq84273n5g211 Yep, it's a pain, but Collections predates Java 8 and uses custom functional interfaces. This would...

Hi @Claudenw Please see my comment in [COLLECTIONS-869](https://issues.apache.org/jira/browse/COLLECTIONS-869).

Hello @Stefal Thank you for your PR. New public and protected elements should have a Javadoc comment that includes a since tag. This PR needs a unit test to prove...

Hello @Stefal Thank you for your updates. Please run `mvn` before you push to run and fix all build checks. I'm not sure which exact version of Exif we support...

@Stefal I'll review later today or tomorrow. Ty!