Gary Gregory
Gary Gregory
@kvr000 Please revert the First/Last APIs.
No tests. Code coverage is down. No proof of performance change one way or another. Non-trivial additional complexity. So -1 as it stands. "For extremely rare situations, this PR may...
> > Looks OK to me, though claims of performance improvements really need measurements and benchmarks. > > Here are some JMH benchmark results: [#378 (comment)](https://github.com/apache/commons-compress/pull/378#issuecomment-1501863937) But where is the...
Hello All I am -1 until tests are provided that show the new data structure is correctly populated. A package-private getter can be added and queried by new unit tests...
From my POV, if we do anything, and as a first cut, I would follow the route we are taking in Commons VFS: Move to new modules, format-specific code that...
The problem of deep dependencies can be solved if Compress provides a BOM POM and my app depends on this BOM POM (commons-compress-bom). The refactored Compress can contain an empty...
Using the Maven enforcer plugin?
@alexey-pelykh Make sure you run 'mvn' by itself before you push to run all build checks.
@alexey-pelykh This PR has zero text in its description.