commons-io icon indicating copy to clipboard operation
commons-io copied to clipboard
verified publisher icon apache

Amend description of FilenameUtils#getFullPathNoEndSeparator(String) to reflect correct named user result with trailing slash

Open Philzen opened this issue 1 year ago • 3 comments

Similar to #551, the trailing slash is actually preserved in the result here.

Confirmed to have this behaviour in 2.4 and latest 2.15.1

Philzen avatar Jan 04 '24 11:01 Philzen

Note that we should not treat ~ in any special way since it is a Unix-like shell utility and not a file system functionality.

garydgregory avatar Jan 04 '24 15:01 garydgregory

@elharo @garydgregory i totally see the points you've raised and agree it may be worth tackling the current behaviour in a bugfix.

However, until that happens, i believe it will be worthwhile to sync the JavaDoc with the current behavior to minimize bad surprises when consuming the library.

Philzen avatar Apr 24 '24 13:04 Philzen

Hello @Philzen It looks to me like git master already contains the Javadoc change. What about all the callers of the API?

garydgregory avatar Apr 24 '24 14:04 garydgregory