Gary Gregory

-1 as is: - This PR will break the build: Run `mvn` to run the default Maven goal which in turn runs all build checks - Don't rewrite existing tests:...

Maybe one of the SSH tests is hung: ``` [INFO] Running org.apache.commons.vfs2.provider.sftp.SftpPutChannelTestCase Exception in thread "pool-34-thread-1" java.lang.AssertionError at org.apache.sshd.common.session.AbstractSession.decode(AbstractSession.java:519) at org.apache.sshd.common.session.AbstractSession.messageReceived(AbstractSession.java:236) at org.apache.sshd.common.AbstractSessionIoHandler.messageReceived(AbstractSessionIoHandler.java:58) at org.apache.mina.core.filterchain.DefaultIoFilterChain$TailFilter.messageReceived(DefaultIoFilterChain.java:1015) at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessageReceived(DefaultIoFilterChain.java:650) at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1300(DefaultIoFilterChain.java:49) at...

FYI @raboof All tests passed.

Looks like Java 17 is required.

Closing: Done through profiles in git master.

https://issues.apache.org/jira/browse/IO-842

Let's wait to see what happens with https://issues.apache.org/jira/browse/IO-842 I'll post to the dev mailing list to get a broader audience.

-1: We have to test ALL the code we provide. Also, notice this PR _decreases_ the code coverage percentage: ``` @@ Coverage Diff @@ ## master #495 +/- ## ============================================...

We need to keep the code as is to show it works on Java 18 and up where the default encoding is UTF-8. We should consider undeprecating these methods on...

> We might end up setting up separate JDK 21 CIs, one with UTF-8 and one with something weird like Cp936, to flush out the issues. That sounds good (and...