Gary Gregory
Gary Gregory
On Tue, Sep 3, 2019 at 8:59 PM Bruno P. Kinoshita wrote: > *@kinow* approved this pull request. > > No objections from me, assuming Travis build passes and others...
These are factory methods, they don't validate anything.
In the case of `IllegalArgumentException`, based on the usage within Commons Lang, and in the code bases I've worked on and currently see, `IllegalArgumentException` is used quite often. As you...
Hi All, Before we make this class heavier, let's step back and consider what Java 8's own [Duration](https://docs.oracle.com/javase/8/docs/api/java/time/Duration.html) and [Period](https://docs.oracle.com/javase/8/docs/api/java/time/Period.html) classes have to offer and how this class should interact/interface...
You should really run a local build before creating the PR as this PR fails the build.
It's good that the changes are similar to Commons Configuration but we should preserve the examples in Javadocs and perhaps separate them in a separate section in the Javadoc with...
This method or PR is not great because we are defining our own whitespace instead of reusing Charater.isWhitespace or Charater.isSpaceChar. Shouldn't we be using Charater.isSomething?
Ping. Also, how does this square with the RFCs for Base64, Base32, and Base16 (all the subclasses we implement)? IOW, what C/C++ does is completely irrelevant, it's the RFCs that...
Hello @Simulant87 You'll need to add a test case to this PR that shows at least one failing test when run without the main changes.