Gary Gregory comments

Results 851 comments of


                                            Gary Gregory

Fix for failed test cases when running with root

Hi @PeterAlfredLee If this is still a concern, may you please rebase on master?

Fix for failed test cases when running with root

Hi @PeterAlfredLee If this is still a concern, may you please rebase on master?

Fix for failed test cases when running with root

Ping?

Fix for failed test cases when running with root

Ping?

LANG-1661 - Add methods to ClassUtils to get the class type names in a null-safe manner

Can this be used within Commons Lang? Also, would you rebase on master, please?

Annotated Fraction.java

-1: Red build.

Add methods allowing masking of Strings

Masking might belong in Commons Text, not here in Commons Lang IMO.

Add methods allowing masking of Strings

> As a basic secure functionality it must be in core Java library or better even as a method of `String`. Security functions are "batteries" that must be included. Almost...

added feature: pretty printer utility

I would have thought something like this would be fit better in our framework as a `CSVFormat`.

added feature: pretty printer utility

I've sprinkled comments throughout. I am not sure about how this would fit as a CSVFormat subclass.