Gary Gregory

Results 854 comments of Gary Gregory

-1. Do you understand the difference between a weak and strong reference in a map? Do you you know what will happen if you install this change in an application...

IIRC I think someone contributed a concurrent weak hash map either in this component or in commons-collections, there should be a JIRA ticket... AFK ATM...

Just wait. I have a query on the legal mailing list to check to see if we can reuse the Infinispan version of its concurrent weak key hash map, and...

-1: This makes no sense to me as the exception are not causaly unrelated and you are forcing them to be. This might be a use case for IOExceptionList.

I ended up reworking the underlying so that now the method looks like this ``` public static void close(final Closeable... closeables) throws IOException { IOConsumer.forEach(closeables, IOUtils::close); } ``` See also...

Hi @wodencafe Thank you for your update. Now I see one new method, without any tests, and not used from anywhere. - Should the [] be changed to a ......

-1 This is way to restrictive and makes no sense to me: Only non-root users can perform certain tests? The root user should have all all rights over all files....