Tomoya Fujita comments

Results 1227 comments of


                                            Tomoya Fujita

trafficstars

Client:call generates TimeoutError exception when it is timed out.

@sloretz @clalancette can you take a look at this?

Explicit equality operator between rclcpp::Time and msg::Time

@AiVerisimilitude thank you for sharing good information. > Regardless the outcome for this particular issue, I do think marking the constructor explicit is the way to go, but that raises...

Explicit equality operator between rclcpp::Time and msg::Time

> Since the conversion is also implicit, you don't need to specify so. However, the conversion is to builtin_interfaces::msg::Time which does not have a clock type, so I guess it's...

Explicit equality operator between rclcpp::Time and msg::Time

> If we want to make the assignment explicit, I would instead suggest not providing one and require the construction of a rclcpp::Time first and then assign it makes sense...

Explicit equality operator between rclcpp::Time and msg::Time

@AiVerisimilitude this PR has been on my list for a long time, i will check this in this week.

Explicit equality operator between rclcpp::Time and msg::Time

@AiVerisimilitude this still waiting for the another review. CC: @wjwwood

change rclcpp logger sink or get all the sinks used by rclcpp

> spdlog is not able to find the loggers registered with rclcpp library even though it uses spdlog as the base. no, this is what we cannot do right now...

change rclcpp logger sink or get all the sinks used by rclcpp

@clalancette i think we can move this issue to https://github.com/ros2/rcl_logging. what do you think?

change rclcpp logger sink or get all the sinks used by rclcpp

unfortunately no, we do not have any plan for that.

Adding rmw_request_id_t allocator

@CursedRock17 i am not sure what needs to be done here. @wjwwood can you share your idea or example?