Tomoya Fujita

Results 1231 comments of Tomoya Fujita
trafficstars

@jrutgeer your proposal sounds reasonable, logging allocator should be set before. What about having `rcutils_logging_initialize_allocator` and `rcl_logging_initialize_allocator` to initialize global allocator for `rcl` and `rcutils`? and we can keep `rcutils_logging_initialize_with_allocator`...

> I would be inclined to leave them as they are. They don't harm, and they might be useful if somebody ever needs to make changes to the arguments parsing...

@jrutgeer are you willing to address this? if that is so, we are happy to review 😄

@iuhilnehc-ynos @Barry-Xu-2018 any other proposals other than https://github.com/ros2/rcl/issues/1037#issuecomment-1474747748?

@iuhilnehc-ynos > add an environment variable RCUTILS_DEFAULT_LOGGER_DEFAULT_LEVEL to update the default log level in https://github.com/ros2/rcutils/blob/1db1f16a49378f4693b74296449ee920ff53cffe/src/logging.c#L526. Is that too late to initialize the default level here? for example, during `rcl_init` we...

@mauropasse @alsora this performance? or efficiency issue has known for a long time, thanks! this brings back memory to me. similar things are described in https://github.com/ros2/design/blob/918c09758ed4c0854aa128b9c8ed0051c21a6590/articles/content_filtering.md#problems for development for [Content...

+1 👍 it would be useful if we have something like `rcl_peek_messages` without taking it.

@thebyohazard thanks for the contribution, > The red X for Error Raised on the active state indicates that the original author intended a transition from active to errorProcessing. i think...

@thebyohazard friendly ping, are you still working on this? i think this makes sense but it would be better to discuss and have consensus on design 1st.

I was going to take over, see https://github.com/ros2/design/pull/283. but i do not have time to do it soon.