Tomoya Fujita

Results 1231 comments of Tomoya Fujita
trafficstars

@CursedRock17 @Barry-Xu-2018 So the user is expected to specify `RCLCPP_LOG_MIN_SEVERITY`, and that configure the logging macros for severity during build time. (basically this is for more performance.) i do not...

@CursedRock17 sorry for the confusion, let me try to rephrase it. for user experience, with https://github.com/ros2/rclcpp/pull/2384#issuecomment-1955348527 sample code. - `RCLCPP_LOGGING_ENABLED=1` no problem, that works with configured `RCLCPP_LOG_MIN_SEVERITY`. - `RCLCPP_LOGGING_ENABLED=0`, all...

> Oh, you're saying we don't want the Logger to be available at all, that way we won't have to worry about any incorrect exceptions. yeah, that is what i...

> Lastly, a user who wants to quickly modify a parameter, they may want to use the yaml file, but they can't and they are forced to modify the C++...

- IMO, we do not guarantee all feedback messages must be delivered to the client. (if the goal accept response is not yet delivered, that would be dropped. but eventually,...

@alsora thanks for the review. this will change the action client behavior internally so i need to do more verification locally, and i would like to have more feedback for...

@jmachowinski thanks for the comment. this one is not in the merge queue yet, i need to take some more time to verify this, since this changes the action behavior,...

@wjwwood thanks for the comments. > As to why, I believe (but I don't know for sure, I'm just speculating) the reason is a cultural difference in DDS and ROS,...

> just idea, there could be some opt-in configuration flag for user to allow incompatible QoS to keep the communication explicitly, in that case user must be able to know...