Tomoya Fujita

Results 1231 comments of Tomoya Fujita
trafficstars

As a conclusion to this PR, we are going to close this. According to the discussion above, it seems no objections but feel free to post the comments and reopen....

CI: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=20877)](http://ci.ros2.org/job/ci_linux/20877/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=15180)](http://ci.ros2.org/job/ci_linux-aarch64/15180/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=21559)](http://ci.ros2.org/job/ci_windows/21559/)

@jmachowinski sorry i missed this, here is new CI. CI: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=20938)](http://ci.ros2.org/job/ci_linux/20938/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=15229)](http://ci.ros2.org/job/ci_linux-aarch64/15229/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=21612)](http://ci.ros2.org/job/ci_windows/21612/)

@thomasmoore-torc windows failure https://ci.ros2.org/job/ci_windows/21402/testReport/junit/(root)/rclcpp/test_publisher_with_type_adapter_gtest_missing_result/ seems that it gets crashed on somewhere in `test_large_message_unique`. https://github.com/ros2/rclcpp/blob/f7a7954ae74f1b92164cbc21900b6cf89c5b8e16/rclcpp/test/rclcpp/test_publisher_with_type_adapter.cpp#L367-L386 Do you have any clue for that?

I can not reproduce this failure with linux platform.

> Did the most recent build fail with the same issues after you forced pushed the additional changes? failure really related to this PR, but we can give it a...

@thomasmoore-torc the same failure. I do not have windows either, i would like to ask some help on this verification. in the meantime, i will take a look what went...

@clalancette @alsora any thoughts?

@Crola1702 thanks for the info. I got a question why CI https://github.com/ros2/rclcpp/pull/2443#issuecomment-1978752604 on https://github.com/ros2/rclcpp/pull/2443 could not detect this warning on windows?

@thomasmoore-torc i think https://github.com/ros2/rclcpp/pull/2498 should fix our CI failure, let me try run CI again.