rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

Adding rmw_request_id_t allocator

Open CursedRock17 opened this issue 2 years ago • 2 comments
trafficstars

Feature request

Should rmw_request_id_t's allocator be used in the create_request_header method

Feature description

Added in this commit, there is a TODO within the method create_request_header that wants to utilize rmw_request_id_t with a custom allocator of some sort.

Implementation considerations

This TODO is roughly 8.5 years old, a lot has changed since then especially with rmw, so if this isn't necessary I can just open a PR that removes the TODO. Otherwise, since rmw_request_id_t doesn't have an allocator inside of the class, should this method be using some from of allocator in rclc since it is a C type, in order to efficiently create new request headers?

CursedRock17 avatar Oct 06 '23 03:10 CursedRock17

@CursedRock17 i am not sure what needs to be done here.

@wjwwood can you share your idea or example?

fujitatomoya avatar Oct 27 '23 05:10 fujitatomoya

I'm not 100% sure, but my guess is that the idea is to honor the custom rcutils allocator if the user has set it. So this is probably still valid? Unclear to me. I guess we can wait a little longer for @wjwwood to respond.

clalancette avatar Oct 31 '23 03:10 clalancette