Results 844 comments of Francisco Giordano

I hadn't realized the StackOverflow answer was Solidity. :slightly_smiling_face: Signatures are a decent use case, though a standard like EIP712 doesn't convert them to decimal format. NFT URIs are not...

Fixed by https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3573 where `toString` was changed to binary search (see also the new log functions from #3670). We haven't unrolled the loop. We can consider that if someone wants...

I think this is an elegant solution that makes sense, and doesn't add significant overhead. I don't think we should offer a timestamp-based version out of the box until it's...

@Amxx I think this is unrelated to moving to UDVT. The storage layout in this PR is compatible, right?

I don't think we should have this in the library. There are many ways in which `totalAssets` will be implemented in user code, and as far as I can tell...

I'd like to see the numbers but I believe the bytecode size impact could be significant, and the runtime cost impact may be negligible. The additional cost contains no storage...

We are probably going to move forward with this in 5.0 along with the removal of before and after hooks (replaced with "simple" overriding of `_transfer`). A PR with these...

Just to clarify, we can't remove the contract until the next major release, but if there is consensus we can deprecate it, in the sense of announcing its deprecation, not...

We don't think it should be OpenZeppelin Contracts making the decision to deprecate the ERC. We're happy to include comments in our documentation about the downsides and alternatives. For actual...

@k06a I was going to mention [ERC827](https://github.com/ethereum/EIPs/issues/827) but I see you were involved in that discussion already! I think the approach with CREATE2 is interesting but isn't it an important...