Francisco Giordano

An argument for automating it in doc generation is that if you are looking at the code it's already more or less evident what events are emitted because you can...

I think you're right that in-memory sorting for small bounded arrays could be acceptable and useful. Do you have use cases in mind? What sorting algorithm would you suggest? A...

We could remove the check for the public `approve` function while keeping it for the internal `_approve` function but it will make the code more complex. How much of an...

I think the gas savings are too small (

It's a breaking change so we're not doing it yet.

The implementation in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3017 already reverts if the receiver is not a contract. It's implicit in this line: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a3ef6b445ab5bb8c5d3bf2e6073708ce503bea0a/contracts/token/ERC20/extensions/ERC1363.sol#L105 Are there other differences in this PR? Please see my comment...

Given that there are two competing PRs for this same EIP, I need to take some time to review both and see what are the meaningful differences and how to...

@vittominacori I'm proposing that we move forward with #3017. Once that is merged (which looks straightforward enough), I would like you to contribute some of the things from this PR:...

Yes, we see ERC1363 as an ERC20 extension. I will raise the point about the location of the interface.

So we need to emit the `salt` in an event, but we can't change the existing event because it changes the event selector, which is a little concerning because any...